Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable all hiprand APIs from ROCm 6.2+ and update backward compatibility. #60

Merged
merged 1 commit into from
Jun 20, 2024
Merged

enable all hiprand APIs from ROCm 6.2+ and update backward compatibility. #60

merged 1 commit into from
Jun 20, 2024

Conversation

lcskrishna
Copy link

No description provided.

@lcskrishna
Copy link
Author

the hipRand tests pass:

================================================================= test session starts ==================================================================
platform linux -- Python 3.9.19, pytest-7.3.2, pluggy-1.5.0 -- /opt/conda/envs/py_3.9/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home-folder/work/cupy-bringup/update-hiprand/cupy/.hypothesis/examples')
rootdir: /home-folder/work/cupy-bringup/update-hiprand/cupy
configfile: setup.cfg
plugins: hypothesis-5.35.1, cpp-2.3.0, flakefinder-1.1.0, rerunfailures-14.0, xdist-3.3.1, xdoctest-1.1.0
collected 5 items

tests/cupy_tests/cuda_tests/test_curand.py::TestGenerateNormal::test_invalid_argument_log_normal_double PASSED                                   [ 20%]
tests/cupy_tests/cuda_tests/test_curand.py::TestGenerateNormal::test_invalid_argument_log_normal_float PASSED                                    [ 40%]
tests/cupy_tests/cuda_tests/test_curand.py::TestGenerateNormal::test_invalid_argument_normal_double PASSED                                       [ 60%]
tests/cupy_tests/cuda_tests/test_curand.py::TestGenerateNormal::test_invalid_argument_normal_float PASSED                                        [ 80%]
tests/cupy_tests/cuda_tests/test_curand.py::TestExceptionPicklable::test PASSED                                                                  [100%]

================================================================== 5 passed in 0.55s ===================================================================

bmedishe
bmedishe approved these changes Jun 20, 2024
View reviewed changes
Copy link

@bmedishe bmedishe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AdrianAbeyta
AdrianAbeyta approved these changes Jun 20, 2024
View reviewed changes
Copy link

@AdrianAbeyta AdrianAbeyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianAbeyta AdrianAbeyta merged commit d73d8a4 into ROCm:rocm6.2_internal_testing Jun 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmedishe bmedishe bmedishe approved these changes

@AdrianAbeyta AdrianAbeyta AdrianAbeyta approved these changes

@pnunna93 pnunna93 Awaiting requested review from pnunna93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcskrishna @AdrianAbeyta @bmedishe